Merged
Conversation
Exact same change as microsoft/onnxruntime#24608 in Onnxruntime
This is in code we should deprecate going forward but it's breaking an existing case and this is the quickest fix.
Add backwards compatibility for dml->DML Give a runtime error if DML chosen but if we're not built with DML (otherwise it goes into Ort and it will use DML even if GenAI isn't built for it)
Sets `add_special_tokens` from `OrtxTokenizeWithOptions` added in microsoft/onnxruntime-extensions#940 to false to solve chat template issue in GenAI with extra BOS tokens. See huggingface/transformers#37686 for more context. --------- Co-authored-by: Sayan Shaw <sayanshaw@microsoft.com> Co-authored-by: Ryan Hill <38674843+RyanUnderhill@users.noreply.github.com>
### Description This PR removes generating prompt templates and storing them in the GenAI config. ### Motivation and Context The prompt templates are not used internally anymore.
baijumeswani
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update version to 0.8.0-rc2 and cherry pick these 3 changes:
#1435 update ESRP settings
#1434 make WebGPU name consistent
#1432 Missed an all lowercase "webgpu" string
#1440 Apply provider name backwards compatibility at runtime
#1452 Update Extensions Commit to Support Chat Template Override for Unsupported Models
#1439 Sign macos binaries
#1442 Set
add_special_tokens